[Jifty-commit] r6822 - jifty/trunk/lib/Jifty/Plugin/RequestInspector

Jifty commits jifty-commit at lists.jifty.org
Wed Apr 22 04:37:12 EDT 2009


Author: sartak
Date: Wed Apr 22 04:37:11 2009
New Revision: 6822

Modified:
   jifty/trunk/lib/Jifty/Plugin/RequestInspector/View.pm

Log:
Cleanup, use an ol instead of a table for requests

Modified: jifty/trunk/lib/Jifty/Plugin/RequestInspector/View.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Plugin/RequestInspector/View.pm	(original)
+++ jifty/trunk/lib/Jifty/Plugin/RequestInspector/View.pm	Wed Apr 22 04:37:11 2009
@@ -4,31 +4,33 @@
 use Jifty::View::Declare -base;
 
 template '/__jifty/admin/requests' => page {
+    title => "Request Inspector"
+}
+content {
     my $request_inspector = Jifty->find_plugin('Jifty::Plugin::RequestInspector');
 
-    table {
+    ol {
+        attr { id is 'request-inspector' };
+
         for my $request ($request_inspector->requests) {
-            row {
-                cell { $request->{id} };
-                cell { $request->{url} };
-                cell { sprintf '%.2gs', $request->{end} - $request->{start} };
-            };
-            row {
-                for my $plugin_name (keys %{ $request->{plugin_data} }) {
-                    my $plugin_data = $request->{plugin_data}{$plugin_name};
-                    my $plugin = Jifty->find_plugin($plugin_name);
-
-                    my $summary = $plugin->inspect_render_summary($plugin_data);
-                    next if !defined($summary);
-
-                    $plugin_name =~ s/^Jifty::Plugin:://;
-                    cell { $plugin_name };
-                    cell { $summary };
-
-                    my $analysis = $plugin->inspect_render_analysis($plugin_data);
-                    next if !defined($summary);
-                    cell { $analysis };
-                }
+            li {
+                my $id = $request->{id};
+                attr { id is "request-$id" };
+
+                hyperlink(
+                    label => $request->{url},
+                    onclick => {
+                        element => "#request-$id",
+                        append  => '/__jifty/admin/requests/plugins',
+                        toggle  => 1,
+                        effect  => 'slideDown',
+                        arguments => {
+                            id => $id,
+                        },
+                    },
+                );
+
+                outs sprintf ' (%.2gs)',  $request->{end} - $request->{start};
             };
         }
     };


More information about the Jifty-commit mailing list