[Jifty-commit] r4810 - in Jifty-DBI/trunk: lib/Jifty/DBI

jifty-commit at lists.jifty.org jifty-commit at lists.jifty.org
Thu Jan 10 16:00:29 EST 2008


Author: sartak
Date: Thu Jan 10 16:00:28 2008
New Revision: 4810

Modified:
   Jifty-DBI/trunk/   (props changed)
   Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm

Log:
 r50047 at onn:  sartak | 2008-01-10 15:35:34 -0500
 No need to duplicate order_by's logic, just call thrash explicitly and call add_order_by


Modified: Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm
==============================================================================
--- Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm	(original)
+++ Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm	Thu Jan 10 16:00:28 2008
@@ -1498,13 +1498,8 @@
     my $self = shift;
     return if $self->derived;
     if (@_) {
-        my @args = @_;
-
-        unless ( UNIVERSAL::isa( $args[0], 'HASH' ) ) {
-            @args = {@args};
-        }
-        $self->{'order_by'} = \@args;
-        $self->redo_search();
+        $self->{'order_by'} = [];
+        $self->add_order_by(@_);
     }
     return ( $self->{'order_by'} || [] );
 }


More information about the Jifty-commit mailing list