[Jifty-commit] r4782 - in jifty/trunk: lib/Jifty/Web

[jifty-commit at lists.jifty.org]

Author: sartak
Date: Thu Jan  3 17:15:21 2008
New Revision: 4782

Modified:
   jifty/trunk/   (props changed)
   jifty/trunk/lib/Jifty/Web/Session.pm

Log:
 r49872 at onn:  sartak | 2008-01-03 17:14:31 -0500
 Never send a cookie with cached content. Misbehaving proxies cause terrific problems.


Modified: jifty/trunk/lib/Jifty/Web/Session.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Web/Session.pm	(original)
+++ jifty/trunk/lib/Jifty/Web/Session.pm	Thu Jan  3 17:15:21 2008
@@ -317,6 +317,10 @@
 sub set_cookie {
     my $self = shift;
 
+    # never send a cookie with cached content. misbehaving proxies cause
+    # terrific problems
+    return if Jifty->handler->apache->header_out('Expires');
+
     my $cookie_name = $self->cookie_name;
     my %cookies     = CGI::Cookie->fetch();
     my $cookie = new CGI::Cookie(