[Jifty-commit] r5153 - in jifty/trunk: lib/Jifty lib/Jifty/Plugin/OAuth lib/Jifty/Plugin/OAuth/Model
Jifty commits
jifty-commit at lists.jifty.org
Wed Feb 20 21:07:43 EST 2008
Author: sartak
Date: Wed Feb 20 21:07:42 2008
New Revision: 5153
Modified:
jifty/trunk/ (props changed)
jifty/trunk/lib/Jifty/Handler.pm
jifty/trunk/lib/Jifty/Plugin/OAuth/Dispatcher.pm
jifty/trunk/lib/Jifty/Plugin/OAuth/Model/Consumer.pm
Log:
r51984 at onn: sartak | 2008-02-20 21:07:27 -0500
Log successful OAuths
Modified: jifty/trunk/lib/Jifty/Handler.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Handler.pm (original)
+++ jifty/trunk/lib/Jifty/Handler.pm Wed Feb 20 21:07:42 2008
@@ -262,8 +262,10 @@
sub cleanup_request {
my $self = shift;
+
# Clean out the cache. the performance impact should be marginal.
# Consistency is improved, too.
+
Jifty->web->session->unload();
Jifty::Record->flush_cache if Jifty::Record->can('flush_cache');
$self->cgi(undef);
Modified: jifty/trunk/lib/Jifty/Plugin/OAuth/Dispatcher.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Plugin/OAuth/Dispatcher.pm (original)
+++ jifty/trunk/lib/Jifty/Plugin/OAuth/Dispatcher.pm Wed Feb 20 21:07:42 2008
@@ -219,7 +219,7 @@
my @params = qw/consumer_key signature_method signature
timestamp nonce token version/;
set no_abort => 1;
- my %oauth_params = get_parameters(@params);
+ my %oauth_params = get_parameters(@params);
for (@params) {
abortmsg(undef, "Undefined required parameter: $_"), return if !defined($oauth_params{$_});
}
@@ -261,8 +261,11 @@
abortmsg(undef, "Invalid signature (type: $oauth_params{signature_method})."), return unless $request->verify;
$consumer->made_request(@oauth_params{qw/timestamp nonce/});
+
Jifty->web->temporary_current_user(Jifty->app_class('CurrentUser')->new(id => $access_token->auth_as));
Jifty->web->current_user->is_oauthed($access_token);
+
+ Jifty->log->info("Consumer " . $consumer->name . " successfully OAuthed as user ". $access_token->auth_as);
}
=head2 invalid_method
Modified: jifty/trunk/lib/Jifty/Plugin/OAuth/Model/Consumer.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Plugin/OAuth/Model/Consumer.pm (original)
+++ jifty/trunk/lib/Jifty/Plugin/OAuth/Model/Consumer.pm Wed Feb 20 21:07:42 2008
@@ -96,6 +96,7 @@
sub is_valid_request {
my ($self, $timestamp, $nonce) = @_;
+
return (0, "Timestamp nonincreasing, $timestamp < ".$self->last_timestamp.".")
if $timestamp < $self->last_timestamp;
return 1 if $timestamp > $self->last_timestamp;
More information about the Jifty-commit
mailing list