[Jifty-commit] r5746 - in jifty/trunk: lib/Jifty/Plugin/Chart/Renderer

Jifty commits jifty-commit at lists.jifty.org
Mon Aug 18 11:02:29 EDT 2008


Author: trs
Date: Mon Aug 18 11:02:27 2008
New Revision: 5746

Modified:
   jifty/trunk/   (props changed)
   jifty/trunk/lib/Jifty/Plugin/Chart/Renderer/Google.pm

Log:
 r39381 at zot:  tom | 2008-08-18 11:01:51 -0400
 We need some error handling here so we don't try to divide by zero and (somehow) get hilarious errors like:
 
 Can't locate object method "message" via package "Illegal division by zero at /var/home/perl/5.8.8/lib/site_perl/5.8.8/Jifty/Plugin/Chart/Renderer/Google.pm line 334." (perhaps you forgot to load "Illegal division by zero at /var/home/perl/5.8.8/lib/site_perl/5.8.8/Jifty/Plugin/Chart/Renderer/Google.pm line 334."?)
 


Modified: jifty/trunk/lib/Jifty/Plugin/Chart/Renderer/Google.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Plugin/Chart/Renderer/Google.pm	(original)
+++ jifty/trunk/lib/Jifty/Plugin/Chart/Renderer/Google.pm	Mon Aug 18 11:02:27 2008
@@ -331,6 +331,13 @@
 
 sub _position_in_range {
     my ( $self, $point, $min, $max ) = @_;
+
+    return 0 if not defined $point
+             or not defined $min
+             or not defined $max;
+
+    return $min if $max == $min;
+
     return ($point - $min) / ($max - $min);
 }
 


More information about the Jifty-commit mailing list