[Jifty-commit] r4410 - jifty/trunk/lib/Jifty
jifty-commit at lists.jifty.org
jifty-commit at lists.jifty.org
Sat Nov 10 05:04:48 EST 2007
Author: sunnavy
Date: Sat Nov 10 05:04:05 2007
New Revision: 4410
Modified:
jifty/trunk/lib/Jifty/Test.pm
Log:
refactor Jifty::Test a bit
Modified: jifty/trunk/lib/Jifty/Test.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Test.pm (original)
+++ jifty/trunk/lib/Jifty/Test.pm Sat Nov 10 05:04:05 2007
@@ -69,9 +69,9 @@
sub is_passing {
my $tb = Jifty::Test->builder;
- my $is_failing = 0;
- $is_failing ||= grep {not $_} $tb->summary;
- $is_failing ||= ($tb->has_plan || '') eq 'no_plan'
+ my $is_failing = grep {not $_} $tb->summary;
+ no warnings 'uninitialized';
+ $is_failing ||= $tb->has_plan eq 'no_plan'
? 0
: $tb->expected_tests < $tb->current_test;
@@ -92,7 +92,9 @@
sub is_done {
my $tb = Jifty::Test->builder;
- if( ($tb->has_plan || '') eq 'no_plan' ) {
+
+ no warnings 'uninitialized';
+ if( $tb->has_plan eq 'no_plan' ) {
return $tb->current_test > 0;
}
else {
More information about the Jifty-commit
mailing list