[Jifty-commit] r3528 - jifty/trunk/lib/Jifty/Web/Form

jifty-commit at lists.jifty.org jifty-commit at lists.jifty.org
Mon Jun 18 11:03:44 EDT 2007


Author: audreyt
Date: Mon Jun 18 11:03:37 2007
New Revision: 3528

Modified:
   jifty/trunk/lib/Jifty/Web/Form/Link.pm

Log:
* Web::Form::Link - When escape_label was set, the tooltip property was
  (very sillily!) first escaped, then discarded away, displaying the
  unescaped text instead.  It now escapes properly.
* Also make tooltips with value '0' display properly.

Modified: jifty/trunk/lib/Jifty/Web/Form/Link.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Web/Form/Link.pm	(original)
+++ jifty/trunk/lib/Jifty/Web/Form/Link.pm	Mon Jun 18 11:03:37 2007
@@ -101,12 +101,12 @@
 
     my $tooltip = $self->tooltip;
     $tooltip = Jifty->web->escape( $tooltip )
-        if ( $tooltip and $self->escape_label );
+        if ( defined $tooltip and $self->escape_label );
 
     Jifty->web->out(qq(<a));
     Jifty->web->out(qq( id="@{[$self->id]}"))         if $self->id;
     Jifty->web->out(qq( class="@{[$self->class]}"))   if $self->class;
-    Jifty->web->out(qq( title="@{[$self->tooltip]}")) if $tooltip;
+    Jifty->web->out(qq( title="@{[$tooltip]}"))       if defined $tooltip;
     Jifty->web->out(qq( target="@{[$self->target]}")) if $self->target;
     Jifty->web->out(qq( accesskey="@{[$self->key_binding]}")) if $self->key_binding;
     Jifty->web->out(qq( href="@{[Jifty->web->escape($self->url)]}"));


More information about the Jifty-commit mailing list