[Jifty-commit] r3510 - in Jifty-DBI/trunk: lib/Jifty/DBI

jifty-commit at lists.jifty.org jifty-commit at lists.jifty.org
Fri Jun 15 15:31:47 EDT 2007


Author: trs
Date: Fri Jun 15 15:31:46 2007
New Revision: 3510

Modified:
   Jifty-DBI/trunk/   (props changed)
   Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm

Log:
 r24662 at zot:  tom | 2007-06-15 15:31:17 -0400
 Warn on using accessor with arguments


Modified: Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm
==============================================================================
--- Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm	(original)
+++ Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm	Fri Jun 15 15:31:46 2007
@@ -260,6 +260,7 @@
                 if ( UNIVERSAL::isa( $column->refers_to, "Jifty::DBI::Record" ) )
                 {
                     $subref = sub {
+                        if ( @_ > 1 ) { Carp::carp "Value passed to column accessor.  You probably want to use the mutator." }
                         $_[0]->_to_record( $column_name,
                             $_[0]->__value($column_name) );
                     };
@@ -271,7 +272,10 @@
                 {
                     $subref = sub { $_[0]->_collection_value($column_name) };
                 } else {
-                    $subref = sub { return ( $_[0]->_value($column_name) ) };
+                    $subref = sub {
+                        if ( @_ > 1 ) { Carp::carp "Value passed to column accessor.  You probably want to use the mutator." }
+                        return ( $_[0]->_value($column_name) );
+                    };
                 }
             } else {
                 $subref = sub { return '' }


More information about the Jifty-commit mailing list