[Jifty-commit] r2694 - in jifty/trunk: lib/Jifty/Module

[jifty-commit at lists.jifty.org]

Author: jesse
Date: Sun Jan 28 10:57:04 2007
New Revision: 2694

Modified:
   jifty/trunk/   (props changed)
   jifty/trunk/Makefile.PL
   jifty/trunk/lib/Jifty/Module/Pluggable.pm

Log:
 r21634 at hualien:  jesse | 2007-01-28 23:55:16 +0800
 * Alternate implementation of Module::Pluggable::Object's _require method to avoid a useless string eval.


Modified: jifty/trunk/Makefile.PL
==============================================================================
--- jifty/trunk/Makefile.PL	(original)
+++ jifty/trunk/Makefile.PL	Sun Jan 28 10:57:04 2007
@@ -48,7 +48,7 @@
 requires('Log::Log4perl');
 requires('LWP::UserAgent'); # Net::HTTP
 requires('MIME::Types');
-requires('Module::Pluggable' => '3.1');
+requires('Module::Pluggable' => '3.1'); # Module::Pluggable::Object
 requires('Module::CoreList');
 requires('Module::Refresh');
 requires('Module::ScanDeps');

Modified: jifty/trunk/lib/Jifty/Module/Pluggable.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Module/Pluggable.pm	(original)
+++ jifty/trunk/lib/Jifty/Module/Pluggable.pm	Sun Jan 28 10:57:04 2007
@@ -39,6 +39,7 @@
 
 
 use Module::Pluggable::Object;
+use UNIVERSAL::require;
 sub Module::Pluggable::Object::_require {
     my $self = shift;
     my $module = shift;
@@ -46,11 +47,9 @@
     # Module::Pluggable::Object::_require expects a true value (the error message) on failure
     # On success, it expects you to return undef.
 
-    if (!Jifty::Util->require($module) ) {
-        return $UNIVERSAL::require::ERROR;
-    } else {
-        return undef;
-    }
+    local $UNIVERSAL::require::ERROR = undef;
+    $module->require(); # We'd prefer to use Jifty::Util->require() here, but it spews crazy warnings
+     return $UNIVERSAL::require::ERROR;
 
 
 }