[Jifty-commit] r3808 - in Test-WWW-Declare: lib/Test/WWW t

jifty-commit at lists.jifty.org jifty-commit at lists.jifty.org
Mon Aug 6 13:34:19 EDT 2007


Author: sartak
Date: Mon Aug  6 13:34:18 2007
New Revision: 3808

Modified:
   Test-WWW-Declare/   (props changed)
   Test-WWW-Declare/lib/Test/WWW/Declare.pm
   Test-WWW-Declare/t/01-basic.t
   Test-WWW-Declare/t/02-skip.t
   Test-WWW-Declare/t/03-mech.t
   Test-WWW-Declare/t/04-fail.t
   Test-WWW-Declare/t/05-forms.t
   Test-WWW-Declare/t/06-title.t
   Test-WWW-Declare/t/07-alt-names.t
   Test-WWW-Declare/t/09-multisession.t

Log:
 r29955 at caladan:  sartak | 2007-08-06 13:34:08 -0400
 Test any diags that we spit out


Modified: Test-WWW-Declare/lib/Test/WWW/Declare.pm
==============================================================================
--- Test-WWW-Declare/lib/Test/WWW/Declare.pm	(original)
+++ Test-WWW-Declare/lib/Test/WWW/Declare.pm	Mon Aug  6 13:34:18 2007
@@ -281,7 +281,7 @@
         }
         else
         {
-            $BUILDER->diag("session '$title' failed because $FLOWS_FAILED flows failed");
+            $BUILDER->diag("Session '$title' failed because $FLOWS_FAILED of its flows failed");
         }
     }
     else {

Modified: Test-WWW-Declare/t/01-basic.t
==============================================================================
--- Test-WWW-Declare/t/01-basic.t	(original)
+++ Test-WWW-Declare/t/01-basic.t	Mon Aug  6 13:34:18 2007
@@ -1,5 +1,5 @@
 #!perl
-use Test::WWW::Declare::Tester tests => 5;
+use Test::WWW::Declare::Tester tests => 7;
 use warnings;
 use strict;
 
@@ -24,3 +24,6 @@
 is($results[0]{name}, "basic connectivity", "1st test was flow");
 is($results[1]{name}, "check logins", "2nd test was session");
 
+is($results[0]{diag}, '', 'no warnings/errors');
+is($results[1]{diag}, '', 'no warnings/errors');
+

Modified: Test-WWW-Declare/t/02-skip.t
==============================================================================
--- Test-WWW-Declare/t/02-skip.t	(original)
+++ Test-WWW-Declare/t/02-skip.t	Mon Aug  6 13:34:18 2007
@@ -1,5 +1,5 @@
 #!perl
-use Test::WWW::Declare::Tester tests => 9;
+use Test::WWW::Declare::Tester tests => 11;
 use warnings;
 use strict;
 
@@ -27,3 +27,6 @@
 is($results[1]{skip}, undef, "no skip for session");
 is($results[1]{name}, "check logins", "2nd test was session");
 
+is($results[0]{diag}, '', 'no warnings/errors');
+is($results[1]{diag}, '', 'no warnings/errors');
+

Modified: Test-WWW-Declare/t/03-mech.t
==============================================================================
--- Test-WWW-Declare/t/03-mech.t	(original)
+++ Test-WWW-Declare/t/03-mech.t	Mon Aug  6 13:34:18 2007
@@ -1,5 +1,5 @@
 #!perl
-use Test::WWW::Declare::Tester tests => 7;
+use Test::WWW::Declare::Tester tests => 10;
 use warnings;
 use strict;
 
@@ -24,3 +24,7 @@
 is($results[1]{name}, "basic connectivity", "2nd test was flow");
 is($results[2]{name}, "check logins", "2nd test was session");
 
+is($results[0]{diag}, "", "no warnings/errors");
+is($results[1]{diag}, "", "no warnings/errors");
+is($results[2]{diag}, "", "no warnings/errors");
+

Modified: Test-WWW-Declare/t/04-fail.t
==============================================================================
--- Test-WWW-Declare/t/04-fail.t	(original)
+++ Test-WWW-Declare/t/04-fail.t	Mon Aug  6 13:34:18 2007
@@ -1,5 +1,5 @@
 #!perl
-use Test::WWW::Declare::Tester tests => 7;
+use Test::WWW::Declare::Tester tests => 10;
 use warnings;
 use strict;
 
@@ -31,3 +31,7 @@
 is($results[1]{name}, "should be run", "2nd test was flow");
 is($results[2]{name}, "check logins", "3rd test was session");
 
+like($results[0]{diag}, qr/Content does not match \(?.*?\) at /, "reasonable error message for 'content should match' failing");
+is($results[1]{diag}, '', "no errors/warnings on the second flow");
+like($results[2]{diag}, qr/Session 'check logins' failed because 1 of its flows failed/, "reasonable error message for 'session failed because flow failed'");
+

Modified: Test-WWW-Declare/t/05-forms.t
==============================================================================
--- Test-WWW-Declare/t/05-forms.t	(original)
+++ Test-WWW-Declare/t/05-forms.t	Mon Aug  6 13:34:18 2007
@@ -1,5 +1,5 @@
 #!perl
-use Test::WWW::Declare::Tester tests => 6;
+use Test::WWW::Declare::Tester tests => 9;
 use warnings;
 use strict;
 
@@ -42,3 +42,7 @@
 is($results[1]{name}, "search2", "2nd test was flow");
 is($results[2]{name}, "check logins", "3rd test was sessions");
 
+is($results[0]{diag}, '', 'no errors/warnings');
+is($results[1]{diag}, '', 'no errors/warnings');
+is($results[2]{diag}, '', 'no errors/warnings');
+

Modified: Test-WWW-Declare/t/06-title.t
==============================================================================
--- Test-WWW-Declare/t/06-title.t	(original)
+++ Test-WWW-Declare/t/06-title.t	Mon Aug  6 13:34:18 2007
@@ -1,5 +1,5 @@
 #!perl
-use Test::WWW::Declare::Tester tests => 5;
+use Test::WWW::Declare::Tester tests => 7;
 use warnings;
 use strict;
 
@@ -30,4 +30,6 @@
 is($results[0]{name}, "basic connectivity", "1st test was flow");
 is($results[1]{name}, "check logins", "2nd test was session");
 
+is($results[0]{diag}, '', 'no errors/warnings');
+is($results[1]{diag}, '', 'no errors/warnings');
 

Modified: Test-WWW-Declare/t/07-alt-names.t
==============================================================================
--- Test-WWW-Declare/t/07-alt-names.t	(original)
+++ Test-WWW-Declare/t/07-alt-names.t	Mon Aug  6 13:34:18 2007
@@ -1,5 +1,5 @@
 #!perl
-use Test::WWW::Declare::Tester tests => 5;
+use Test::WWW::Declare::Tester tests => 7;
 use warnings;
 use strict;
 
@@ -29,5 +29,6 @@
 is($results[0]{name}, "basic connectivity", "1st test was flow");
 is($results[1]{name}, "check logins", "2nd test was session");
 
-
+is($results[0]{diag}, '', 'no errors/warnings');
+is($results[1]{diag}, '', 'no errors/warnings');
 

Modified: Test-WWW-Declare/t/09-multisession.t
==============================================================================
--- Test-WWW-Declare/t/09-multisession.t	(original)
+++ Test-WWW-Declare/t/09-multisession.t	Mon Aug  6 13:34:18 2007
@@ -4,7 +4,7 @@
 use strict;
 
 my @testnames = ('a', 'b', 'visit FORMY', 'c', 'argy mech', 'visit GOOD', 'd', 'f', 'visit FORMY', 'e', 'visit GOOD', 'visit FORMY');
-plan tests => 1 + 2 * @testnames;
+plan tests => 1 + 3 * @testnames;
 
 my @results = run_tests(
     sub {
@@ -58,3 +58,5 @@
     is($results[$_-1]{name}, $testnames[$_-1], "correct test name for test $_");
 }
 
+for (1.. at testnames) { is($results[$_-1]{diag}, '', "no errors/warnings") }
+


More information about the Jifty-commit mailing list