[Jifty-commit] r3789 - in jifty/trunk: . lib/Jifty/Plugin/Chart/Renderer

jifty-commit at lists.jifty.org jifty-commit at lists.jifty.org
Sat Aug 4 18:31:06 EDT 2007


Author: sterling
Date: Sat Aug  4 18:31:06 2007
New Revision: 3789

Modified:
   jifty/trunk/   (props changed)
   jifty/trunk/lib/Jifty/Plugin/Chart/   (props changed)
   jifty/trunk/lib/Jifty/Plugin/Chart/Renderer/PlotKit.pm

Log:
 r8371 at dynpc145:  andrew | 2007-08-04 17:30:09 -0500
  r8357 at dynpc145:  andrew | 2007-08-04 16:33:37 -0500
  Fixed typos in the new type handling code and fixed error handling.
 


Modified: jifty/trunk/lib/Jifty/Plugin/Chart/Renderer/PlotKit.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Plugin/Chart/Renderer/PlotKit.pm	(original)
+++ jifty/trunk/lib/Jifty/Plugin/Chart/Renderer/PlotKit.pm	Sat Aug  4 18:31:06 2007
@@ -55,13 +55,16 @@
         horizontalbars => { type => 'bar', orientation => 'horizontal' },
     );
 
+    # save it for error reporting
+    my $orig_type = $args{type};
+
     # Make sure the type is ready to be used
     my $options = $types{ $args{type} } || {};
-    $args{type} = delete $options{type};
-    $args{options}{$_} = $options{$_} foreach keys %$options;
+    $args{type} = delete $types{type};
+    $args{options}{$_} = $types{$_} foreach keys %types;
 
     if ( not defined $args{type} ) {
-        Jifty->log->warn("Unsupported chart type: $args{type}!");
+        Jifty->log->warn("Unsupported chart type: $orig_type!");
         return;
     }
 


More information about the Jifty-commit mailing list