[Jifty-commit] r2024 - jifty/trunk/share/web/static/js

[jifty-commit at lists.jifty.org]

Author: hlb
Date: Sat Oct 14 01:55:16 2006
New Revision: 2024

Modified:
   jifty/trunk/share/web/static/js/bps_util.js
   jifty/trunk/share/web/static/js/jifty.js

Log:
* remove useless check in buttonToLink to get performance boost.


Modified: jifty/trunk/share/web/static/js/bps_util.js
==============================================================================
--- jifty/trunk/share/web/static/js/bps_util.js	(original)
+++ jifty/trunk/share/web/static/js/bps_util.js	Sat Oct 14 01:55:16 2006
@@ -16,22 +16,18 @@
     return Jifty.Calendar.registerDateWidget( id );
 }
 
-function buttonToLink(input) {
-    var e = $(input);
-    if (e) {
-        var link = document.createElement("a");
-        link.setAttribute("href","#");
-        link.setAttribute("onclick",e.getAttribute("onclick"));
-        link.setAttribute("name",e.getAttribute("name"));
-        link.className = e.className;
-        link['virtualform'] = Form.Element.getForm(e);
-        link.appendChild(document.createTextNode(e.getAttribute("value")));
-
-        e.parentNode.insertBefore(link, e.nextSibling);
-        e.parentNode.removeChild(e);
-        return true;
-    }
-    return false;
+function buttonToLink(e) {
+    var link = document.createElement("a");
+    link.setAttribute("href","#");
+    link.setAttribute("onclick",e.getAttribute("onclick"));
+    link.setAttribute("name",e.getAttribute("name"));
+    link.className = e.className;
+    link['virtualform'] = Form.Element.getForm(e);
+    link.appendChild(document.createTextNode(e.getAttribute("value")));
+
+    e.parentNode.insertBefore(link, e.nextSibling);
+    e.parentNode.removeChild(e);
+    return true;
 }
 
 // onload handlers

Modified: jifty/trunk/share/web/static/js/jifty.js
==============================================================================
--- jifty/trunk/share/web/static/js/jifty.js	(original)
+++ jifty/trunk/share/web/static/js/jifty.js	Sat Oct 14 01:55:16 2006
@@ -441,10 +441,7 @@
         }
     },
     'input.button_as_link': function(e) {
-        if ( !Element.hasClassName( e, 'is_button_as_link' ) ) {
-            buttonToLink(e);
-            Element.addClassName( e, 'is_button_as_link' );
-        }
+        buttonToLink(e);
     },
     "input.date, input.text": function(e) {
         /* XXX TODO: Figure out how to make our enter handler detect