[Jifty-commit] r678 - Jifty-DBI/trunk/lib/Jifty Jifty-DBI/trunk/lib/Jifty/DBI

jifty-commit at lists.jifty.org jifty-commit at lists.jifty.org
Wed Mar 8 01:47:37 EST 2006


Author: jesse
Date: Wed Mar  8 01:47:36 2006
New Revision: 678

Modified:
   /   (props changed)
   Jifty-DBI/trunk/Changes
   Jifty-DBI/trunk/META.yml
   Jifty-DBI/trunk/SIGNATURE
   Jifty-DBI/trunk/lib/Jifty/DBI.pm
   Jifty-DBI/trunk/lib/Jifty/DBI/HasFilters.pm
   Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm
   Jifty-DBI/trunk/lib/Jifty/DBI/Schema.pm

Log:
 r25817 at truegrounds:  jesse | 2006-03-07 22:42:10 -0800
 * Added a "filters" alias for input_filters and output_filters


Modified: Jifty-DBI/trunk/Changes
==============================================================================
--- Jifty-DBI/trunk/Changes	(original)
+++ Jifty-DBI/trunk/Changes	Wed Mar  8 01:47:36 2006
@@ -1,6 +1,10 @@
+Revision history for Perl extension Jifty::DBI.
 
+* Added "filters" method to records, which adds both input_filters and output_filters.
 
-Revision history for Perl extension Jifty::DBI.
+0.17 Sun Mar  5 00:41:41 PST 2006
+
+* Memcached correctness fixes
 
 0.16 Sat Mar  4 18:02:44 PST 2006
 

Modified: Jifty-DBI/trunk/META.yml
==============================================================================
--- Jifty-DBI/trunk/META.yml	(original)
+++ Jifty-DBI/trunk/META.yml	Wed Mar  8 01:47:36 2006
@@ -26,4 +26,4 @@
   Lingua::EN::Inflect: 0
   UNIVERSAL::require: 0
   perl: 5.8.3
-version: 0.15
+version: 0.17

Modified: Jifty-DBI/trunk/SIGNATURE
==============================================================================
--- Jifty-DBI/trunk/SIGNATURE	(original)
+++ Jifty-DBI/trunk/SIGNATURE	Wed Mar  8 01:47:36 2006
@@ -14,10 +14,10 @@
 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1
 
-SHA1 f79f0b889acf9ac7ddbb0c6ae7cfb943c09808f8 Changes
+SHA1 68f570fefe364b26c569bc5ce7a49ac933e6a69d Changes
 SHA1 507297e1572993e94413173b2f3d5fb386be85ab MANIFEST
-SHA1 1231893dac98c4fcfbb812330ff1bb1af4319455 META.yml
-SHA1 5907726fe0575dc8bacbe69a284fb121b23d2f7c Makefile.PL
+SHA1 11d0829c83c5efd40d4ae2aba18d29303e7c8145 META.yml
+SHA1 fdfcf1a1c7d2d17852b82ae0eef90fb0bea786bc Makefile.PL
 SHA1 d0943ab047f543c92405564ab77ba008052544e6 README
 SHA1 82d6ac3f6def48558d09f8b6e3b53ed4194d8c81 ROADMAP
 SHA1 c28087e498978a1a314dfcaa584844703f31ac8c doc/notes/on_intuitive_schema_definitions
@@ -35,7 +35,7 @@
 SHA1 49e0d839edeb0f3e9af12fd2444b98365393a23e inc/Module/Install/Metadata.pm
 SHA1 2a1b494a7e5adaa3216e86d909dd5bf87d084c80 inc/Module/Install/Win32.pm
 SHA1 4a23fafe534363a99f0d936df9086ad243e692c9 inc/Module/Install/WriteAll.pm
-SHA1 246a6625e4a2dcfb0d0768ef7e973838cc1bb284 lib/Jifty/DBI.pm
+SHA1 ea6c43a3148aba017e0ee346c5545f0d97082ebe lib/Jifty/DBI.pm
 SHA1 ef358d9e6f42704e2926a7a9461bb1ad9bd0b1ef lib/Jifty/DBI/Collection.pm
 SHA1 ecfae7430da875a856113e0c233daa0e31073000 lib/Jifty/DBI/Collection/Union.pm
 SHA1 07115934091da72e0025c9c754714fc0ceedbef5 lib/Jifty/DBI/Collection/Unique.pm
@@ -58,7 +58,7 @@
 SHA1 e1f3f71be76647b8a93ce5d00c988c25bb435e5a lib/Jifty/DBI/HasFilters.pm
 SHA1 76c87fb8ec1d422f767781cd0473689ef3134587 lib/Jifty/DBI/Record.pm
 SHA1 84899c21647b64df6d0cad3ff4c3b376e27cb3a8 lib/Jifty/DBI/Record/Cachable.pm
-SHA1 c3715f0e49368259d1a1c9e67cc59385458d407b lib/Jifty/DBI/Record/Memcached.pm
+SHA1 2f375afad7b20d32a69b9bde03488a5d544537ed lib/Jifty/DBI/Record/Memcached.pm
 SHA1 5aac9a0114416331ea76ac6a2f291bbe8b83df8c lib/Jifty/DBI/Schema.pm
 SHA1 08423bd2486097cf4f3b116901b12e8c948f0fa8 lib/Jifty/DBI/SchemaGenerator.pm
 SHA1 597d121dd76e0e5d05b818e44474f6c3ad48fe64 t/00.load.t
@@ -79,7 +79,7 @@
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.1 (GNU/Linux)
 
-iD8DBQFECkSsEi9d9xCOQEYRAqHoAKC+tOWOhEjjDHGqM9cA6PT0mvWHbgCff6ft
-zlF5ogMPMqa99zA6/Nm8/ig=
-=8LcT
+iD8DBQFECqRrEi9d9xCOQEYRApk4AJ9ke+2v5Jcs27/+hhHVfMHQmQ8OAACghVR9
+A2Xw+euRVX0Z6AFAgA0kNPE=
+=ByQV
 -----END PGP SIGNATURE-----

Modified: Jifty-DBI/trunk/lib/Jifty/DBI.pm
==============================================================================
--- Jifty-DBI/trunk/lib/Jifty/DBI.pm	(original)
+++ Jifty-DBI/trunk/lib/Jifty/DBI.pm	Wed Mar  8 01:47:36 2006
@@ -2,7 +2,7 @@
 use warnings;
 use strict;
 
-our $VERSION = '0.16';
+our $VERSION = '0.17';
 
 =head1 NAME
 

Modified: Jifty-DBI/trunk/lib/Jifty/DBI/HasFilters.pm
==============================================================================
--- Jifty-DBI/trunk/lib/Jifty/DBI/HasFilters.pm	(original)
+++ Jifty-DBI/trunk/lib/Jifty/DBI/HasFilters.pm	Wed Mar  8 01:47:36 2006
@@ -7,6 +7,7 @@
 __PACKAGE__->mk_accessors qw/
     input_filters
     output_filters
+    filters
     /;
 
 =head1 NAME
@@ -71,6 +72,21 @@
     return reverse $self->input_filters;
 }
 
+=head2 filters FILTERS
+
+Sets the input and output filters at the same time.  Returns a hash,
+with keys C<input> and C<output>, whose values are array references to
+the respective lists.
+
+=cut
+
+sub filters {
+    my $self = shift;
+    return {output => $self->output_filters(@_),
+            input  => $self->input_filters(@_)
+	    };
+}
+
 =head1 SEE ALSO
 
 L<Jifty::DBI::Filter>

Modified: Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm
==============================================================================
--- Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm	(original)
+++ Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm	Wed Mar  8 01:47:36 2006
@@ -568,7 +568,9 @@
             )
             || (   defined $args{'value'}
                 && defined $self->{'values'}{ $column->name }
-                && $args{'value'} eq $self->{'values'}{ $column->name } )
+		   # XXX: This is a bloody hack to stringify DateTime
+		   # and other objects for compares
+                && $args{value}."" eq "".$self->{'values'}{ $column->name } )
             )
         {
             $ret->as_array( 1, "That is already the current value" );
@@ -576,18 +578,19 @@
         }
     }
 
-    my $method = "validate_" . $column->name;
-    my ( $ok, $msg ) = $self->$method( $args{'value'} );
-    unless ($ok) {
-        $ret->as_array( 0, 'Illegal value for ' . $column->name );
-        $ret->as_error(
-            errno        => 3,
-            do_backtrace => 0,
-            message      => "Illegal value for " . $column->name
-        );
-        return ( $ret->return_value );
-    }
+    
 
+	my $method = "validate_" . $column->name;
+	my ( $ok, $msg ) = $self->$method( $args{'value'} );
+	unless ($ok) {
+	    $ret->as_array( 0, 'Illegal value for ' . $column->name );
+	    $ret->as_error(
+			   errno        => 3,
+			   do_backtrace => 0,
+			   message      => "Illegal value for " . $column->name
+			   );
+	    return ( $ret->return_value );
+	}
     # The blob handling will destroy $args{'Value'}. But we assign
     # that back to the object at the end. this works around that
     my $unmunged_value = $args{'value'};

Modified: Jifty-DBI/trunk/lib/Jifty/DBI/Schema.pm
==============================================================================
--- Jifty-DBI/trunk/lib/Jifty/DBI/Schema.pm	(original)
+++ Jifty-DBI/trunk/lib/Jifty/DBI/Schema.pm	Wed Mar  8 01:47:36 2006
@@ -40,7 +40,7 @@
 use Carp qw/carp/;
 use Exporter::Lite;
 our @EXPORT
-    = qw(column type default validator immutable unreadable length distinct mandatory not_null valid_values label hints render_as since input_filters output_filters is by are on virtual);
+    = qw(column type default validator immutable unreadable length distinct mandatory not_null valid_values label hints render_as since input_filters output_filters filters is by are on virtual);
 
 our $SCHEMA;
 
@@ -214,6 +214,18 @@
     _item( [ distinct => 1 ] );
 }
 
+=head2 filters
+
+Sets a list of filters on the data.  These are applied when reading
+B<and> writing to the database.  Correct usage is C<input_filters are
+'Jifty::DBI::Filter::DateTime'>.  See L<Jifty::DBI::Filter>.
+
+=cut
+
+sub filters ($) {
+    _list( input_filters => shift );
+}
+
 =head2 input_filters
 
 Sets a list of input filters on the data.  Correct usage is


More information about the Jifty-commit mailing list