[Jifty-commit] r1351 - in jifty/trunk: lib/Jifty/Web/Form lib/Jifty/Web/Form/Field

[jifty-commit at lists.jifty.org]

Author: seanmil
Date: Thu Jun 22 15:47:23 2006
New Revision: 1351

Modified:
   jifty/trunk/   (props changed)
   jifty/trunk/lib/Jifty/Web/Form/Field.pm
   jifty/trunk/lib/Jifty/Web/Form/Field/Password.pm

Log:
 r574 at pc102:  sean | 2006-06-22 15:47:16 -0400
 * Backed out r1349, re-add autocomplete="off" tag


Modified: jifty/trunk/lib/Jifty/Web/Form/Field.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Web/Form/Field.pm	(original)
+++ jifty/trunk/lib/Jifty/Web/Form/Field.pm	Thu Jun 22 15:47:23 2006
@@ -415,11 +415,15 @@
 =head2 other_widget_properties
 
 If your widget subclass has other properties it wants to insert into the html
-of the main widget and you haven't subclassed render_widget you can subclass
-this to do so.
+of the main widget and you haven't subclassed render_widget then you can just
+subclass this.
+
+If you have subclassed render_widget then just stick them in your local sub
+render_widget.
+
+We use this for marking password fields as not-autocomplete so the browser does
+not try to use its form autocompletion on them.
 
-Otherwise, if you have already subclassed render_widget, just stick them in
-your local sub render_widget.
 
 =cut
 

Modified: jifty/trunk/lib/Jifty/Web/Form/Field/Password.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Web/Form/Field/Password.pm	(original)
+++ jifty/trunk/lib/Jifty/Web/Form/Field/Password.pm	Thu Jun 22 15:47:23 2006
@@ -25,6 +25,10 @@
 
 Never render anything for autocompletion.
 
+No browser-based form auto-completion in password fields ;)
+
+Note: This has nothing to do with Jifty's Autocomplete mechanism.
+
 =cut
 
 sub render_autocomplete {''}