[Jifty-commit] r1608 - in jifty/branches/moose: doc lib/Jifty

[jifty-commit at lists.jifty.org]

Author: audreyt
Date: Tue Jul 18 21:47:13 2006
New Revision: 1608

Modified:
   jifty/branches/moose/   (props changed)
   jifty/branches/moose/doc/packaging
   jifty/branches/moose/lib/Jifty/Web.pm

Log:
 r16365 at T (orig r1606):  nelhage | 2006-07-18 10:25:55 -0400
 J::Web::redirect can take a Clickable as arg, so make goto do that, instead of passing a URL with parameters, which doesn't work right
 r16391 at T (orig r1607):  jesse | 2006-07-18 21:44:35 -0400
  r14160 at pinglin:  jesse | 2006-07-18 21:43:13 -0400
   * packaging plan updates
 


Modified: jifty/branches/moose/doc/packaging
==============================================================================
--- jifty/branches/moose/doc/packaging	(original)
+++ jifty/branches/moose/doc/packaging	Tue Jul 18 21:47:13 2006
@@ -39,3 +39,40 @@
 
     jifty install/uninstall
         * some sort of management. will also work on plugins
+
+
+
+# A dist blib builder
+
+# A dist blib packager (->zip with a makefile.pl - it works as a par and as a dist)
+
+# Package multiple dists as a single dist.
+
+# Pony: an automatic deps-writer that will design a list of deps for 
+the systemwide currently installed modules.
+
+
+# Must include shared libs (expat, svn, etc)
+
+# Some way to deal with systemwide shared libs, like Pg
+
+# an alien extractor that analyzes already-built XS libs (in either blib/ or sitelib)
+with platform-specific tools (ldd, xtools, etc) and pull in shared libraries, similar
+to how Alien::* currentl does it in a case-by-case basis.
+
+# A dist blib upgrader
+
+# A cpan workalike for jifty dists
+
+# An installation scheme for
+
+    {$INSTALL_DIR,$APP_DIR}/share/jifty/deps/{`archname`,noarch}
+
+
+# one blib/ directory for the tuple of
+    (dist, version, `arch` or "noarch" , perl version?)
+
+# an @INC populator     
+    pushes a glob for arch-independent  (rename this: blib-noarch/*
+    pushes a glob for per-arch libs  blib-`arch`/*
+

Modified: jifty/branches/moose/lib/Jifty/Web.pm
==============================================================================
--- jifty/branches/moose/lib/Jifty/Web.pm	(original)
+++ jifty/branches/moose/lib/Jifty/Web.pm	Tue Jul 18 21:47:13 2006
@@ -16,6 +16,7 @@
 use XML::Writer;
 use CSS::Squish;
 use Digest::MD5 qw(md5_hex);
+use Carp qw(carp);
 use base qw/Class::Data::Inheritable Jifty::Object/;
 
 use vars qw/$SERIAL @JS_INCLUDES/;
@@ -542,7 +543,7 @@
     }
 }
 
-=head3 redirect [URL]
+=head3 redirect [TO]
 
 Redirect to the next page. If you pass this method a parameter, it
 redirects to that URL rather than B<next_page>.
@@ -559,7 +560,7 @@
     $page = Jifty::Web::Form::Clickable->new( url => $page )
       unless ref $page and $page->isa("Jifty::Web::Form::Clickable");
 
-    warn "Don't include GET paramters in the redirect URL -- use a Jifty::Web::Form::Clickable instead.  See L<Jifty::Web/redirect>" if $page->url =~ /\?/;
+    carp "Don't include GET paramters in the redirect URL -- use a Jifty::Web::Form::Clickable instead.  See L<Jifty::Web/redirect>" if $page->url =~ /\?/;
 
     my %overrides = ( @_ );
     $page->parameter($_ => $overrides{$_}) for keys %overrides;
@@ -698,7 +699,7 @@
 sub goto {
     my $self = shift;
     Jifty->web->redirect(
-        Jifty::Web::Form::Clickable->new(@_)->complete_url );
+        Jifty::Web::Form::Clickable->new(@_));
 }
 
 =head3 link PARAMHASH
@@ -755,7 +756,7 @@
 
     $self->render_error_messages($only_moniker);
     $self->render_success_messages($only_moniker);
-    
+
     return '';
 }