[Jifty-commit] r497 - Jifty-DBI/trunk/lib/Jifty/DBI

[jifty-commit at lists.jifty.org]

Author: autrijus
Date: Wed Jan 11 23:40:57 2006
New Revision: 497

Modified:
   Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm

Log:
* Jifty::DBI::Collection - Fix two misuse of keys():
    - to test hash emptiness, simply use the hash.
    - to build subclauses, we should sort the keys first just like restrictions.

Modified: Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm
==============================================================================
--- Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm	(original)
+++ Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm	Wed Jan 11 23:40:57 2006
@@ -316,7 +316,7 @@
 
 sub _is_joined {
     my $self = shift;
-    if ( keys( %{ $self->{'leftjoins'} } ) ) {
+    if ( %{ $self->{'leftjoins'} } ) {
         return (1);
     }
     else {
@@ -873,7 +873,7 @@
     #Various subclauses.
     
     my @subclauses;
-    foreach my $subclause ( keys %{ $self->{'subclauses'} } ) {
+    foreach my $subclause ( sort keys %{ $self->{'subclauses'} } ) {
         push @subclauses, $self->{'subclauses'}{"$subclause"};
     }