[Jifty-commit] r1845 - in jifty/trunk: t

[jifty-commit at lists.jifty.org]

Author: mark
Date: Wed Aug 23 09:20:21 2006
New Revision: 1845

Modified:
   jifty/trunk/   (props changed)
   jifty/trunk/t/01-dependencies.t

Log:
 r1610 at travis:  mark | 2006-08-23 14:19:30 +0100
 added diagnostics to tell me which file was using the missing module


Modified: jifty/trunk/t/01-dependencies.t
==============================================================================
--- jifty/trunk/t/01-dependencies.t	(original)
+++ jifty/trunk/t/01-dependencies.t	Wed Aug 23 09:20:21 2006
@@ -22,13 +22,14 @@
     return if $File::Find::dir =~ m!/.svn($|/)!;
     return if $File::Find::name =~ /~$/;
     return if $File::Find::name =~ /\.pod$/;
+    my $filename = $_;
     local $/;
-    open(FILE, $_) or return;
+    open(FILE, $filename) or return;
     my $data = <FILE>;
     close(FILE);
-    $used{$1}++ while $data =~ /^\s*use\s+([\w:]+)/gm;
+    $used{$1}{$filename}++ while $data =~ /^\s*use\s+([\w:]+)/gm;
     while ($data =~ m|^\s*use base qw.([\w\s:]+)|gm) {
-        $used{$_}++ for split ' ', $1;
+        $used{$_}{$filename}++ for split ' ', $1;
     }
 }
 
@@ -50,7 +51,8 @@
     my $first_in = Module::CoreList->first_release($_);
     next if defined $first_in and $first_in <= 5.00803;
     next if /^(Jifty|Jifty::DBI|inc|t|TestApp|Application)(::|$)/;
-    ok(exists $required{$_}, "$_ in Makefile.PL");
+    ok(exists $required{$_}, "$_ in Makefile.PL")
+      or diag("used in ", join ", ", sort keys %{ $used{$_ } });
     delete $used{$_};
     delete $required{$_};
 }